search

DinoDevs / GladiatusCrazyAddon

This was "A browser addon for the Gladiatus browser game."
https://gladiatus.dinodevs.com
GNU General Public License v3.0
41 stars 32 forks source link

Menu - auction quick links #362

Closed FrutyX closed 2 years ago

FrutyX commented 2 years ago

@GreatApo eyyyyyyyyyyyyyyy, what do ya say?

FrutyX commented 2 years ago

Food not included because it is already in the shortcuts bar.

GreatApo commented 2 years ago

The reason I haven't added these links is because we need to drop support for the quick link to the second auction. I believe it is more important to have a quick link to the second auction.

FrutyX commented 2 years ago

Ah, you can never make it easy, can you? Alright, I think we can have both, but I will have to play with it more and see what I can do.

FrutyX commented 2 years ago

Uh, I don't have any ideas today.

With the latest commit to this, I can at least show you what I was trying to achieve.

First, it's stupid to add the same script again with only few things edited and second, there is a problem that the opacity does not stay when the page is refreshed and icons are shown, obviously because it's on a onclick function.

I've been just doing some spaghetti....

FrutyX commented 2 years ago

I've fixed the opacity thing, however it's a code mess I would say, if Thanos sees this, he will lose all his hair, for me, it's a working mess, hehe.

Now I'll await Apo's response (hopefully not Gram's, muhehe).

GreatApo commented 2 years ago

I've fixed the opacity thing, however it's a code mess I would say, if Thanos sees this, he will lose all his hair, for me, it's a working mess, hehe.

Now I'll await Apo's response (hopefully not Gram's, muhehe).

I still don't see how you can directly (one click) go to the the second auction... which I think it is more important than going directly to specific categories. Personally I never use these shortcuts for the market either. We do have the function that remembers the last category you visited which probably does most of the job nice and easy

FrutyX commented 2 years ago

"Second auction", I am not sure if I get you right, you mean to the "For mercenaries" section, right?

The original button stayed: this.convertMenu.addPlus(this.info.auction, this.info.auction_active, {href : gca_getPage.link({"mod":"auction","ttype":"3"})});

It's there. Both are there.

And I am 100% sure someone requested shortcuts to auction categories, especially to mercenaries only (not the section).

FrutyX commented 2 years ago

Does this ring any bell?

auc

GreatApo commented 2 years ago

Yes, that is probably the best you can do (sorry I thought it was commented in the code). I will have a better look and try to fix some style problems too.

FrutyX commented 2 years ago

It's not perfect, but it does what it's supposed to do and it does not look that bad.

There was no space to try another solution and I did not want it to go outside the menu, that would look horrible. I've been running it all day and it seems fine, no errors logged. As usually, you can review and improve the code for the best results, in it's current state - it's working just fine.

FrutyX commented 2 years ago

Whoah, so you did some big changes to it, and made it ten times better, it indeed looks nice now, it needed much more changes in the end. Nice and thanks :).

FrutyX commented 2 years ago

@GreatApo by the way, I am not sure if you noticed, but after a page refresh with the menu opened, it's colliding with the ">", but it's a small design thing.

cld

GreatApo commented 2 years ago

@GreatApo by the way, I am not sure if you noticed, but after a page refresh with the menu opened, it's colliding with the ">", but it's a small design thing.

cld

Oups