Underworld error - detecting yourself

[FrutyX]

Taken from #311

This one is appearing when your underworld copy drops something, GCA fails to detect the enemy and throws an error.

<div id="costumeAnimation_62b849e548476" class="avatar avatar_costume_part avatar_costume_animation" style="z-index: 0; background-image: url("9425/img/costumes/sets/male/3_complete.png"); background-position: -1848px 0px;"></div>

It also seems it's only for secondary drops, primary was fine:

No error here.

GramThanos: Its the addon trying to detect the materials drioped by the enemies. Here the enemy is yourself, thus it doesn't have an NPC number.

[FrutyX]

@GreatApo & @GramThanos when you'll be fixing the currently bugged enemy detection script, could you also check this and adjust it to it? Two for one.

Or perhaps it will fix itself by reworking it, depends on how you rework it.

[GramThanos]

Technically this is not an error. It's just a warning.

[FrutyX]

But only technically. :D

Well then, tell javascript to ignore this if this, it actually does not need fixing.

[FrutyX]

A bit problematic to test it, I will see tomorrow when I am back in UW.

[GreatApo]

I was able to test it from my report by disabling the timer and bypassing the material check. I am not sure if it will work if you don't wear an animated costume...

Ps: the drop is not saved anyway...

[FrutyX]

I am afraid that with this change ( c551889 ), you created errors even in regular reports (you two are brothers, aren't you 😄).

I have tons of these errors:

Uncaught TypeError: Cannot read properties of undefined (reading 'replace')

https://s34-cz.gladiatus.gameforge.com/game/index.php?mod=reports&submod=showCombatReport&t=0&reportId=8397465&sh=

core/source/reports.js?4.3.6&built=1658387951508:207

and it happens in every report, where there is secondary drop:

But the fact that detect enemies is still bugged (reverse lookup url errors) isn't really helping too I guess.

[GreatApo]

I am afraid that with this change ( c551889 ), you created errors even in regular reports (you two are brothers, aren't you 😄).

Yes, sorry, that's on me. Yes, we are brothers :)

[FrutyX]

@GreatApo But I have some good news too, I just dropped it in UW and haven't got any error, also I did not wear any costume.

However, there is some symbol stuff in the resource image :D

[FrutyX]

If helpful, this is the avatar URL:

gf2.geo.gfsrv.net/cdn12/124a63795958541c73a4e72afa1eb1.jpg

[GramThanos]

My code is flawless, I caused no errors.

[FrutyX]

Of course Thanos, always is.

[FrutyX]

Wasted my UW points, but I can confirm that the fix is actually working, with or without an costume, only there are two new problems:

• Without a costume, there are strange symbols in the material image (screenshot above)
• Regular reports (non-UW) are throwing an "replace" error when a secondary drop is dropped

[FrutyX]

Patched in v4.3.6, closing, re-open if needed.