Gladiatus Update 4.3.1 Bugs

[FrutyX]

Gameforge moved their images to a new URL location, so images GCA is using are not being loaded and that is causing a mess.

Reports are failing to detect enemies URL:

🟢 Status: FIXED

`Failed to detect enemy url("//gf3.geo.gfsrv.net/cdn29/bac7e539d61a9de6caec21363c2694.jpg")`

Mystery box rubies prices unknown:

🟢 Status: FIXED


Pantheon quests bugged:

🟢 Status: FIXED

``` pantheon.quests.js?4.3.6&built=1658150383374:82 Uncaught TypeError: Cannot read properties of null (reading '1') at Object.quests_reorder (pantheon.quests.js?4.3.6&built=1658150383374:82:122) at Object.inject (pantheon.quests.js?4.3.6&built=1658150383374:15:9) at fireLoad (pantheon.quests.js?4.3.6&built=1658150383374:180:23) ```

Guild battle report bugged:

🟢 Status: FIXED


Add to Target List bugged:

🟢 Status: FIXED


Gold&XP Statistics Icon bugged:

🟢 Status: FIXED


Negotium X enemies bugged:

🟢 Status: FIXED


Buffs bugged when viewing other player profiles:

🟢 Status: FIXED


CT and Dungeons table overview bugged:

🟢 Status: FIXED

 ``` Failed to load resource: the server responded with a status of 404 (Not Found) char_status_kopf_b.jpg:1 Failed to load resource: the server responded with a status of 404 (Not Found) char_status_abschluss_b.jpg:1 ```

Durability loss numbers are bugged with GCA enabled:

🟢 Status: FIXED


Attack guild button missing in War Master Hall:

🟢 Status: FIXED


Library level indicator bugged:

🟢 Status: FIXED


... more will be added when found.

[GramThanos]

https://gf1.geo.gfsrv.net/cdnf8/78e9dd30a5e0f07d5be66c9bae9dd4.jpg https://gf3.geo.gfsrv.net/cdn29/bac7e539d61a9de6caec21363c2694.jpg

These 2 are already in the data.

[FrutyX]

And should this "failed" error occur, with data added?

[GramThanos]

If you have the last version of the extension I guess no.

[FrutyX]

I thought so, and yet, I am still getting these errors.

[GramThanos]

I thought so, and yet, I am still getting these errors.

Both links return a value, thus you shouldn't get an error.

gca_tools.img.resolve('https://gf1.geo.gfsrv.net/cdnf8/78e9dd30a5e0f07d5be66c9bae9dd4.jpg')

gca_tools.img.resolve('https://gf3.geo.gfsrv.net/cdn29/bac7e539d61a9de6caec21363c2694.jpg')

[FrutyX]

I have my suspicion, I'll be back when I confirm or deny it.

[FrutyX]

Confirmed, a secondary drop is causing this errors (very #368 related):

Failed to detect enemy url("//gf3.geo.gfsrv.net/cdn29/bac7e539d61a9de6caec21363c2694.jpg")

[FrutyX]

Even the symbols came back for this one!

[FrutyX]

You need this for the list?

https://gf3.geo.gfsrv.net/cdn8b/84fd3f76ff45db7d2cdbf5680aa09b.png

[FrutyX]

Helpful?

https://gf3.geo.gfsrv.net/cdnb8/86e9550484e557ea7b3e0b4a825490.jpg https://gf2.geo.gfsrv.net/cdn4a/19e794899bda1deaf03b3339a2e6f3.jpg

[FrutyX]

Confirmed, a secondary drop is causing this errors :

And it does look like, that the secondary drop has to be a material, for this error to happen.

[FrutyX]

So, a recommended To-Do List before a version launch (only things I am currently aware of):

• Pull request #402
• Once #402 is done, I still have some CSS improvements ready to implement
• You may want to check the "Failed to detect enemy" (explained above) error
• Last but not least there is the mystery box showing weird ruby values on some items, if you want to check that too

Time to time I get some random error, harmless ones I would say, unfortunately my browser dumped my error logs, probably because they were overspammed, but like I said, they are random and harmless with no priority, I haven't noticed anything that would break the extension, they can also appear now thanks to the loading times, which is absolutely understandable.

[FrutyX]

Added by Thanos!

Nile event enemies: ``` Image link "//gf1.geo.gfsrv.net/cdn65/9f45b7fd7ac900004dcafc2feec57d.jpg" was not found on CDN lookup list. Image link "//gf2.geo.gfsrv.net/cdn10/f0a5434c803bde1ba0913aecd9751b.jpg" was not found on CDN lookup list. Image link "//gf2.geo.gfsrv.net/cdnae/23d6d58d2cf752711ec4a580848476.jpg" was not found on CDN lookup list. Image link "//gf2.geo.gfsrv.net/cdn74/531075909c1e2cb313eda2bc1e8c8e.jpg" was not found on CDN lookup list ```

[FrutyX]

I think I have done everything I wanted to do, everything is currently in the testing phase, I may do some little enhancements, bug fixing and this kind of stuff and the more time we have for testing, the better, however, the biggest question of all questions, when we are going to release the new version? The wolf is already knocking at the door, it's almost about time.

The current problems are mentioned above, but these are mostly between us, things people probably will not even notice.

[FrutyX]

I am off to sleep, you take the wheel Thanos, improve but just don't break anything, I worked hard on it as an javascript amateur :D.

[FrutyX]

• Last but not least there is the mystery box showing weird ruby values on some items, if you want to check that too

Yo what, I just had a look, you mind explaining to me why you put some weird values on it, before I'll edit it so it makes sense?

Like why for example "hamper" : {rubies : 1.07}, (cervisia) has such value? It's an item that cannot be bought, so you can't put a price tag on it, same goes for 100% healing potion (but we could use the price of Centurion activation, because you get it with it).

Someone has been lazy! :D

[FrutyX]

Alright, they have to be placeholders, right?

[FrutyX]

Well, I would say that's another thing solved.

[GramThanos]

If something can not by bought I suggest to show nothing. We dont have to add more translations. (In greek the unbuyable is "Δεν μπορεί να αγοραστεί" or something like "μη εξαγοράσιμο" ... I would like to see you fitting that in the column).

Regarding the 1.07: you can buy 14 days centurion for 15 rubies thus 1.0714285714285714 rubies per day. Thus 1 cervicia (24hours) could be 1.07 rubies.

[FrutyX]

Jesus christ, Greek problems... everything so long.

And about these mathematics... I really don't think this is needed, interesting to know but a little useless, you cannot buy 1 day cent anyway. Sometimes it's better to go simple.

[GramThanos]

Ideally the rubies numbers are for people wanting to understand what the gain is from the rewards and help them assess whether it make sense to refresh or not. Further more one could also aggregate the rubies values on the rewards and open only boxes with high gain. But for this to be done, the user's opinion on what exactly they are interesting in is more important.

[FrutyX]

Fine, Fine, if you like it so much, do you have a revert commits button there? Feel free to revert it, if not, I'll change it.

There was also Mobilization and Gate Key for 3 rubies (can't buy), magical bag for -1 (can't buy) and costumes for 50 (can't buy).

[FrutyX]

Should've explained this to me 24 or 17 days ago, when I was mentioning it, and not when I make changes to it...

Thanos The Troll.

[GramThanos]

Look, I just say my opinion, I am not here to revert changes. If you think this should change maybe it should.

I argue so that we can reach a consensus. Thus, if you still think they are not needed, we can remove them.

[FrutyX]

I have made some changes.

• Mobilization and Gate key cannot be bought, but found in the Chest = 1 for 7 rubies.
• 100% Healing Potion you get get one when activating 14 days Centurion = 1 for 15 rubies.
• Magical Bag can be found in the Chest = 1 for 7 rubies.
• Costumes can be found in the Chest = 1 for 7 rubies.
• Cervisia is back at it's previous value according to the calculations.

[FrutyX]

By the way, this is most likely a bug, and costumes are not recognized even with the value, shown as "?".

[FrutyX]

Image link "https://gf3.geo.gfsrv.net/cdnba/fb5aa808eb79bf95e982817b87ff72.jpg" was not found on CDN lookup list.

But I added it on the list? https://github.com/DinoDevs/GladiatusCrazyAddon/commit/6426fea3e8be3858e4b190afa897ff8c0e44acb1

'img/costumes/sets/male/{pluto-we-dont-know-this}.jpg' : 'fb5aa808eb79bf95e982817b87ff72', // Pluto

I tried refreshing the addon.

[GramThanos]

There is a ba missing from the string. It was supposed to be:

'img/costumes/sets/male/{pluto-we-dont-know-this}.jpg' : 'bafb5aa808eb79bf95e982817b87ff72', // Pluto

[FrutyX]

Ah so, didn't know that.

[GramThanos]

Ah so, didn't know that.

i probably forgot to copy the 2 chars next to the '/cdn'

[FrutyX]

Well, with this fixed, if this is supposed to show the costume prices, it doesn't work, not related to the cdn link.

    // game/assets/img/costumes/sets/male/7_complete_small.jpg
            costumes : {rubies : 7}
        },

[FrutyX]

Thanos, I would just like to remind you, that people that don't use the dev version (so 99.9% GCA users), are having a broken extension, I hate pushing and annoying you, but it's maybe time... I am not seeing anything with high priority that is a problem, the mystery chest does not show costumes ruby values which is a very small bug and the failed to detect enemy error, well, that is happening only on a secondary material drop, and I've checked the reports and the drop is normally saved, so it's basically only a console warning, but it does not really break the extension in any way.

Other than that, I haven't even detected any other errors, of course there is always still room for improvements, bug fixing and new features, but like this, we would never release a new version.

[GramThanos]

Hey. I used the flows I scripted a few months ago to push the versions. I think they run correctly. Lets see.

[GramThanos]

Update, I got an email from Firefox that the version is live. Wrong, it is the offline version.

[FrutyX]

[FrutyX]

It seems it's live on Firefox store.

[FrutyX]

Okie, I moved everything relevant to it's own issues, and this seems to be completed.

From what I know from Apo (about Thanos), I will keep the finished issues open for one or two weeks after the release (in case there are any problems) and then close them all, for moderation purposes.

[GramThanos]

Purge everything.

[FrutyX]

I love purging!

[FrutyX]

Patched in v4.3.6, closing, re-open if needed.