Manifest v3 breaks v4.3.6

[GramThanos]

The manifest v3 broke the addon. The current version on chrome store don't runs at all. I am working on a fix.

[FrutyX]

Ouch, I don't even know how that happened.

[FrutyX]

I just went for a small nap, and everything went to hell 😆, this is the biggest release ever lol.

[FrutyX]

Both on dev (local) and stable (store) versions (Google Chrome):

Error in event handler: ReferenceError: document is not defined at loadScript (chrome-extension://dfbmiedjenagoegiiabjfjpkhfocifkp/core/background.js:45:15) at needScript (chrome-extension://dfbmiedjenagoegiiabjfjpkhfocifkp/core/background.js:34:3) at actionManager (chrome-extension://dfbmiedjenagoegiiabjfjpkhfocifkp/core/background.js:67:11) at chrome-extension://dfbmiedjenagoegiiabjfjpkhfocifkp/core/background.js:80:2

But it does not seem to stop the extension.

[FrutyX]

It's almost unbelievable how many people you have awakened by breaking the addon for a day, the forums, discord, store reviews... :D

[GramThanos]

I know... it's fun to look at the statistics :P

Quiz: Can you spot when the problem happend? GitHub:

Gladiatus Crazy Addon Website:

[FrutyX]

:D :D

[FrutyX]

[GramThanos]

Ahhhh.... the GIF-Fu is strong with this one.

[FrutyX]

@GramThanos if I select this:

I see this:

there used to be numbers, no? Is it bugged? Can you check it please?

[FrutyX]

Ahhh, I see, I forgot we have a documentation, I was never using this (using the % option) and I thought it bugged, nevermind, sorry to bother you @GramThanos :D

[GreatApo]

Ahhh, I see, I forgot we have a documentation, I was never using this (using the % option) and I thought it bugged, nevermind, sorry to bother you @GramThanos :D

Only the color changes with that option

[FrutyX]

In it's current state, you can't load the dev version from a folder in Firefox? I've tried manifest.json and manifest_v2.json and both are throwing the same error.

[ACTION FAILED] TEMPORARY_EXTENSION_INSTALL_FAILURE: Unsupported manifest version: 3 [error-logging.js:16:17]

manifestVersionCheck@resource://gre/modules/Schemas.jsm:305:11 [error-logging.js:27:17]
postprocess@resource://gre/modules/Schemas.jsm:1288:59
normalize@resource://gre/modules/Schemas.jsm:2294:17
checkProperty/r<@resource://gre/modules/Schemas.jsm:2059:16
withPath@resource://gre/modules/Schemas.jsm:649:14
checkProperty@resource://gre/modules/Schemas.jsm:2058:25
normalize@resource://gre/modules/Schemas.jsm:2131:14
normalize@resource://gre/modules/Schemas.jsm:3612:23
normalize@resource://gre/modules/Schemas.jsm:3819:28
_getNormalizedManifest@resource://gre/modules/Extension.jsm:1169:25
parseManifest@resource://gre/modules/Extension.jsm:1242:33

It's not about me tho, I just want to prevent any future extension problems, I am not watching it closely, but it is very likely, that Thanos does some changes so it works on Firefox.

[FrutyX]

Ah, I see, I always get the idea AFTER I ask here, I renamed the manifest_v2 to manifest and it works.

I only got:

Reading manifest: Warning processing externally_connectable: An unexpected property was found in the WebExtension manifest.

But I suppose that's nothing important.