search

DinoDevs / GladiatusCrazyAddon

This was "A browser addon for the Gladiatus browser game."
https://gladiatus.dinodevs.com
GNU General Public License v3.0
41 stars 29 forks source link

Lemuren - ingredients #439

Open jkamin61 opened 1 year ago

jkamin61 commented 1 year ago

Ingredients of second enemy in Dragon Remains (Germania) are not shown. As below. Bez tytułu

FrutyX commented 1 year ago

Thanks for the report, you are right, it seems to be bugged.

Now for some digging, she is 2/1_30.jpg, she has set her drops and the cdn image link seems to be alright too.

This for example, seems to be working too: https://s51-en.gladiatus.gameforge.com/cdn/img/npc/2/1_30.jpg

Unless I missed something, she does not appear to be any different from other npcs, but I have a screenshot, and she used to work.

FrutyX commented 1 year ago

I found the problem, well, GCA did, I only found it and enabled it in the code.

gca.cdn.js?4.3.8&built=1668212086109:59 Image link "//gf1.geo.gfsrv.net/cdn93/230fc8d3268e05c79944a17ca8b58b.jpg" has duplicates. 93230fc8d3268e05c79944a17ca8b58b (2) ['img/npc/0/1_36.jpg', 'img/npc/2/1_30.jpg']

The other one is causing it, however, this is not a mistake, one enemy in "Revenge of the Dead" event is using the same image, if you delete the event one, it works normally.

@GramThanos got any easy tweak in mind?

GramThanos commented 1 year ago

I think I pointed out the problem when I scripted the walk around for the CDN images translation. This can't be fixed as the image is the same for multiple NPCs thus by looking at the CDN URL you don't know which NPC is it.

There is no easy fix for that.

FrutyX commented 1 year ago

For this particular case, there actually is a workaround.

If our regular Lemuren is on the list first (before the event one), it loads the drops, so I swapped the location order in the cdn file (it's now from higher location to lower).

I have a screenshot of the event location as well, the other Lemuren did not have any drops shown, so there will be no problem with that.

event_pomsta

FrutyX commented 1 year ago

Alright then, I did a full locations sweep, and only found out, that with swapping the numbers, I only created more problematic duplicates.

So I reverted it, and found out, that Lemures seems the only one problematic, so I did it just simple, I put her on top of the list, you could do that with other duplicates too, but others with drops does not seems to have problems, so there is no need.

GreatApo commented 1 year ago

Nice

jkamin61 commented 1 year ago

The problem reoccurred image

GreatApo commented 2 months ago

In the current dev version, this works: image