search

DinoDevs / GladiatusCrazyAddon

This was "A browser addon for the Gladiatus browser game."
https://gladiatus.dinodevs.com
GNU General Public License v3.0
41 stars 29 forks source link

Problem loading gca_resources on Firefox #440

Open amauryblin opened 1 year ago

amauryblin commented 1 year ago

Describe the bug At least the gold and exp data cannot work on Firefox due to an error in the path while loading gca_resources. The path seems hard-coded to look for the resources folder on chrome-extension, so on other browsers that won't work.

From the source code in source/core/source/gca.info.js var gca_resources = { "folder": "chrome-extension://" + gca_extension.id + "/core/resources/", "audio": "chrome-extension://" + gca_extension.id + "/core/resources/audio/" };

Screenshots (optional)

2022-11-19 21_44_01-Window

Console errors (optional) (see screenshot)

Browser info (optional)

FrutyX commented 1 year ago

Thanks for the report.

I think this might be related to manifest problems, it's probably gonna be wise, to wait for Thanos for his answer...

( This could be related, or it completely isn't https://github.com/DinoDevs/GladiatusCrazyAddon/discussions/389#discussioncomment-4151053 )

FrutyX commented 1 year ago

https://github.com/DinoDevs/GladiatusCrazyAddon/commit/1ba2c4ffc94b13d7be8cba69f0976b1938014557 Yeah, this is definitely related to the manifest changes:

pub

... this is the public Firefox version, Firefox is using moz-extension://.

We have to wait for @GramThanos anyways, for the version release, so this is the first priority and then we can most likely (if no other bugs found) get a new version out, when Thanos has time, of course.

GramThanos commented 1 year ago

Patched at 5c062b0ba318d90adb23b2c0aff24c774d94a77e

GramThanos commented 2 months ago

Let's close this. On my tests, Firefox works ok.