DinoDevs / GladiatusCrazyAddon

This was "A browser addon for the Gladiatus browser game."
https://gladiatus.dinodevs.com
GNU General Public License v3.0
41 stars 29 forks source link

Suppress floating price info on double click buy/sell #447

Open Arctomachine opened 1 year ago

Arctomachine commented 1 year ago

Brief feature description Add option (or force default behavior) to suppress floating notifications with item price (i.e. +1000) on buy/sell when doing it with double click. Why: text of this price gets in the way of other items, so double clicking them is registered as word selection instead. It becomes big obstacle when time to sell is critical.

Add a image as an example (advanced + optional) double-click

FrutyX commented 2 months ago

A rather simple implementation, pure CSS, easily changeable and fixable.

GramThanos commented 2 months ago

A better solution to the problem is to disable the click events on the floating prices all together using:

pointer-events: none;

We can apply that everywhere, without a need of an option.

FrutyX commented 2 months ago

You see, we can use both, since I already created it.

You can disable the floating prices completely (that's an unplanned new feature then), but also, it can be a part of my Gladiatus site improvements (#403).

Best from both worlds.

GreatApo commented 2 months ago

@FrutyX this shouldn't be by default enabled as other players may like the test. Thanos' proposal would be better, assuming that the click even is not blocked by the floating text.

Feel free to move it to the global script so it doesn't have to be added in every other script.

FrutyX commented 2 months ago

You know what, I am not gonna touch this any further.

GreatApo commented 2 months ago

pointer-events: none;

My bad, I see you have already changed to Thanos' proposal... nice!

And I can also verify that it works nicely!