Make check working as documented

DinoTools / monitoring-check_haproxy

Monitoring plugin to check HAProxy with Icinga, Nagios and other compatible monitoring solutions

https://DinoTools.github.io/monitoring-check_haproxy/

GNU General Public License v2.0

7 stars 4 forks source link

Make check working as documented #9

Closed kepi closed 2 years ago

kepi commented 2 years ago

There were multiple problems in code causing this check to do totally different things than advertised. Mainly returning different states then it should, warn/crit when everything was ok.

This commit fixes argument parsing, debug messages and mainly parsing of backend up/down states.

This includes previous PR#8

Again, I made some test, but not extensively. It works in our environment and finally provide correct data, but there might be other edge cases which I overlooked.

phibos commented 2 years ago

Thanks for providing the patch. I have to do some tests before merging it.

phibos commented 2 years ago

Looks like there are still some issues with your patch. I'm fixing the issues and will open a new merge request. Maybe we should release this as new 1.2.0 version.

phibos commented 2 years ago

Your changes and additional fixes have been included in a new PR #11