search

DinoTools / python-overpy

Python Wrapper to access the Overpass API
https://python-overpy.readthedocs.io/
MIT License
235 stars 58 forks source link

Be able to specify a custom overpass server #34

Closed Frankkkkk closed 7 years ago

Frankkkkk commented 7 years ago

Sometimes it can be useful to specify a custom overpass server (many requests, delayed diffs, etc.).

By default, overpass-api.de is still used, but the user can specify another if they want.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 94.301% when pulling 86c1da41d8070bb1de614ab56a043ce5639b38d6 on Frankkkkk:master into dde33b01e327631f132962776791e1e30a6ea4e4 on DinoTools:master.

phibos commented 7 years ago

Thanks for your contribution. I like your idea but I think it would be more clear if the parameter is named url instead of overpass_server.

Frankkkkk commented 7 years ago

How about renaming both url and overpass_server to overpass_server_url ? I know that url should be comprehensible, but overpass_server_url seems without confusion.

Thanks

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.9%) to 93.401% when pulling c4423a84bc9604c457e19919a554faa39de5506a on Frankkkkk:master into dde33b01e327631f132962776791e1e30a6ea4e4 on DinoTools:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.1%) to 94.416% when pulling c4423a84bc9604c457e19919a554faa39de5506a on Frankkkkk:master into dde33b01e327631f132962776791e1e30a6ea4e4 on DinoTools:master.

phibos commented 7 years ago

Please create one pull request per feature and make smaller commits.