search

DinoTools / python-overpy

Python Wrapper to access the Overpass API
https://python-overpy.readthedocs.io/
MIT License
235 stars 58 forks source link

Add GitHub Actions and set support to Python 2.7,3.6-3.9 #87

Closed eumiro closed 3 years ago

eumiro commented 3 years ago
Issue type
Summary

Add GitHub Actions CI and set the currently tested versions to 2.7, 3.6, 3.7, 3.8, and 3.9.

I've kept the 2.7, but would like to ask you to consider dropping it. Python 3.6 is the oldest currently supported version, so I have dropped all prior Python 3.x versions.

The results of the GitHub Actions CI won't be immediately visible as it is still not in the master branch, but will appear after the merge.

eumiro commented 3 years ago

You can see the results of the GitHub Actions CI at https://github.com/eumiro/python-overpy/actions/runs/506314306

coveralls commented 3 years ago

Coverage Status

Coverage decreased (-0.1%) to 94.548% when pulling 75c148ff3ee31f7ce4847c243c95e88f142d850a on eumiro:gha-py39 into cc0cf1993f129036e35a958a519c76bfad88891f on DinoTools:master.

phibos commented 3 years ago

Thanks for your contribution. Do we still need to test against Python 2.7? It has been deprecated this year.

phibos commented 3 years ago

The github actions also report the coverall statistics? Does it make any sense to keep the travis builds?

eumiro commented 3 years ago

Of course, 2.7 should be dropped, but let's do it step by step:

  1. see that GHA works
  2. drop Travis
  3. drop Python 2.7 and refactor the code to Python 3

We're at 1. :-)

eumiro commented 3 years ago

And GHA works: https://github.com/eumiro/python-overpy/actions/runs/506314306

phibos commented 3 years ago

I have split your changes into multiple PRs (#89, #91 and #93). Thanks for your work. Please contact me if anything is missing.