search

DinoTools / python-ssdeep

Python wrapper for ssdeep fuzzy hashing library
GNU Lesser General Public License v3.0
152 stars 30 forks source link

setup.py bdist_rpm creates conflicting rpm #22

Closed neonknight closed 7 years ago

neonknight commented 7 years ago

Building an rpm file using python setup.py bdist_rpm will generate an rpm file currently named ssdeep-3.2-1.x86_64.rpm which will conflict with ssdeep rpm from e.g. EPEL which would provide ssdeep binary.

My suggestion to resolve this issue: set __title__ = "python-ssdeep" in ssdeep/__about__.py

Addionally I added a setup.cfg to faciliate building the rpm package.

dino-bot commented 7 years ago

Can one of the admins verify this patch?

phibos commented 7 years ago

Thank you for your contribution. But at the moment I don't think this is the way to go. Just renaming the package to build a rpm package will also result in a new name in the PyPI and the hard coded dependencies in the setup.cfg might break if the package should be build on an other rpm based distribution or for an other Python version. I would recommend a spec file to build a package.

Did I miss something? Is there a chance to fix the issues?

phibos commented 7 years ago

PR revoked by author see #23 for more information