search

DinographicPixels / TouchGuild

TouchGuild is a NodeJS library for interfacing with Guilded.
https://touchguild.com
MIT License
10 stars 6 forks source link

CVE-2007-4559 Patch #27

Closed TrellixVulnTeam closed 2 years ago

TrellixVulnTeam commented 2 years ago

Patching CVE-2007-4559

Hi, we are security researchers from the Advanced Research Center at Trellix. We have began a campaign to patch a widespread bug named CVE-2007-4559. CVE-2007-4559 is a 15 year old bug in the Python tarfile package. By using extract() or extractall() on a tarfile object without sanitizing input, a maliciously crafted .tar file could perform a directory path traversal attack. We found at least one unsantized extractall() in your codebase and are providing a patch for you via pull request. The patch essentially checks to see if all tarfile members will be extracted safely and throws an exception otherwise. We encourage you to use this patch or your own solution to secure against CVE-2007-4559. Further technical information about the vulnerability can be found in this blog.

If you have further questions you may contact us through this projects lead researcher Kasimir Schulz.

pakkographic commented 2 years ago

Hello, Thanks for creating this pull request. We're not the owner of the node module called node-gyp, by downloading the TouchGuild module, NPM creates a fresh installation of node-gyp, so the vulnerability is still there.

pakkographic commented 2 years ago

Removed node_modules (.gitignore).