Dinones / Nintendo-Switch-Pokemon-Shiny-Hunter

Search for shiny pokémon on your Nintendo Switch while sleeping!
Other
78 stars 5 forks source link

False Negative on Shiny Arceus #44

Open MMartin1211 opened 2 weeks ago

MMartin1211 commented 2 weeks ago

I was using the program to shiny hunt Arceus when the shiny appeared but was flagged as not shiny by the program. I'm guessing this is due to a timing issue as there is a cutscene that plays before the battle begins. The screenshot taken by the program shows that the pokemon is shiny, but the image is from right when the battle is starting and is very clouded due to the fade-in.

1727567916

David34920 commented 2 weeks ago

Hello Martin, I'm currently hunting it, you have to update the value of 'SHINY_ENCOUNTERS_DELAY' to 9

This value is used to skip the cutscene.

It's not validated yet but it's seems working well for me.

I hope the next shiny you found the app will recognize it!

David

MMartin1211 commented 1 week ago

Thank you @David34920, that does seem to help. The screenshot shows the "A wild Arceus appeared!" frame now. I'll update this thread if I'm able to confirm that the program can now detect the shiny.

David34920 commented 1 week ago

I am using 8.5 now. With 9, sometime the captured frame is my Pokémon instead of Arceus.

I'll also update the thread if I'm able to find the shiny Arceus :)

MCPika commented 1 week ago

@David34920 Yeah I'm having the same issue with a quirk XD I'm currently hunting Dialga once more but on the first time you ever see it and I wanted to shiny hunt it at this point in the game. But seems I need to make adjustments on the timer AND the fact that I need to move forward for that specific time. Have you encountered that issue?

David34920 commented 1 week ago

For Palkia, I have put 4 and it worked. But the same, 3.5 could be better.

About Arceus, I think there is more tweak to do, I believe I have encountered shinies but not detected because Arceus is white, and at some moments, the app checks for white pixels... I will do more tries and I will give my result here.

Dinones commented 1 week ago

But seems I need to make adjustments on the timer AND the fact that I need to move forward for that specific time. Have you encountered that issue?

You should not have any issue moving forward. If you have the latest version of the program, it always moves forward for all static encounters; then, presses A until the player enters the combat so you will skip all the text interaction too.

MCPika commented 1 week ago

You should not have any issue moving forward. If you have the latest version of the program, it always moves forward for all static encounters; then, presses A until the player enters the combat so you will skip all the text interaction too.

Yep I do have the latest version I just had forgotten to switch the Move_Static_Encounter variable from False to True So its okay I adjusted xD

David34920 commented 1 week ago

@MCPika you can try to use the code in this PR https://github.com/Dinones/Nintendo-Switch-Pokemon-Shiny-Hunter/pull/48 Don't forget to update your constants to put 6.5 for the delay.

I'm currently testing it.