Diogo-ss / 42-header.nvim

Neovim header for 42 projects. Written in Lua.
MIT License
30 stars 5 forks source link

Add a option to search for user and email in ~/.gitconfig #10

Closed FxmousKid closed 5 months ago

FxmousKid commented 6 months ago

First of all thanks a lot for writing this very useful extension for us nvim users.

My suggestion is basically this : have a option that will make the header email and user be based on the info of the gitconfig, if it's a repo the file being edited is currently in.

I'm pretty sure this is not as straightforward as i make it sound, and would love to help you with this if you need any help.

Diogo-ss commented 6 months ago

Thank you very much for your feedback. You've really come up with a great idea. I don't think it will be that difficult to develop this feature.

I've created a branch to develop it, pull requests are welcome :D As soon as I have some free time, I'll start working on it.

FxmousKid commented 6 months ago

No problem man ! this kind of personal work is very much appreciated, when i see that someone devoted time for something that will help others and still maintain it, it really makes me respect them.

As for a potential pull request, i'll have a look at the dev branch and potentially do one when i have time and get familiar with your source code. Would you mind if i asked you some implementation questions? (i'm still new to neovim, and have basically no experience in lua, sorry, but i'll learn !).

Thank you and have a great day

On Tue, Mar 19, 2024 at 8:50 PM Diogo Silva @.***> wrote:

Assigned #10 https://github.com/Diogo-ss/42-header.nvim/issues/10 to @FxmousKid https://github.com/FxmousKid .

— Reply to this email directly, view it on GitHub https://github.com/Diogo-ss/42-header.nvim/issues/10#event-12174830881, or unsubscribe https://github.com/notifications/unsubscribe-auth/AITFYCTHLQ2RJPW5LQH63OLYZCJF7AVCNFSM6AAAAABE6AOQQOVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSGE3TIOBTGA4DQMI . You are receiving this because you were assigned.Message ID: @.***>

Diogo-ss commented 6 months ago

If you have any questions, feel free to ask. I'll try to help.

FxmousKid commented 6 months ago

Alright Alright, thank you for the cooperation, i'll see what i'll be able to do solo, and get back to you, cya !

On Tue, Mar 19, 2024 at 9:15 PM Diogo Silva @.***> wrote:

If you have any questions, feel free to ask. I'll try to help.

— Reply to this email directly, view it on GitHub https://github.com/Diogo-ss/42-header.nvim/issues/10#issuecomment-2008051278, or unsubscribe https://github.com/notifications/unsubscribe-auth/AITFYCUTB745GI3U375W4GTYZCMFRAVCNFSM6AAAAABE6AOQQOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBYGA2TCMRXHA . You are receiving this because you were mentioned.Message ID: @.***>

Diogo-ss commented 5 months ago

I've added git support. you can use both global and local values. It is disabled by default to maintain compatibility.

commit