DiouxX / docker-glpi

Project to deploy GLPI with docker
239 stars 188 forks source link

Pre-impelment database parameters inside the container #106

Open compgeniuses opened 8 months ago

compgeniuses commented 8 months ago

At the moment, the container seems to be asking the user from the user interface to add their database details, which is countr intuitive,

WOuld it not be great if we could have the container automatically use the configured variables to acheive this.

We can do this by

Mounting the following file inside the glpi files

config_db.php

then inside it, we add the follwing

youll need to adopt the variables to yours,

Wouldnt this solve the problem?

A previous attempt here solved the problem https://github.com/stephdl/nethserver-glpi-10-latest/blob/ns7/root/etc/e-smith/templates/etc/glpi/config_db.php/10base

DiouxX commented 8 months ago

I understand the request and it's true that it could be more intuitive.

I wonder if it wouldn't be better to leave the possibility of entering database information via the installation.

In my opinion, both options should be available.

compgeniuses commented 8 months ago

its better in a docker setup because most of the time, the person deploying is parsing the env variables somehow, so if these database are entered somehwere, then it makes sense that they are used and implemented.

Using your image, we have implemented it here https://github.com/geniusdynamics/docker-glpi we are also attempting to have the same implemented with the glpi pre-built into the docker image. that way even when ofline, someone can start the image its on the genius-glpi branch of the same link

DiouxX commented 8 months ago

All right, I'll add this feature to the roadmap.

Before that, I need to update the image to use Debian 12