DiouxX / docker-glpi

Project to deploy GLPI with docker
235 stars 184 forks source link

Use GitHub API to retrieve the release download url #16

Closed pcortellezzi closed 6 years ago

pcortellezzi commented 6 years ago

Hello,

This commit resolv #15 and #13 by using download url from json api.

DiouxX commented 6 years ago

Hi,

Your pull request is functionnal to download GLPI source and it's more pratical.

But your modification to test if folder GLPI is empty isn't functionnal. I've checked your command on a little test scenario.

Test this script :

#!/bin/bash

if [ -d /tmp/test ]
then
        echo "Folder is empty"
else
        echo "Folder isn't empty"
fi

And you will see that isn't OK.

Maybe make an another commit about only download GLPI source

pcortellezzi commented 6 years ago

Hello,

Yes sorry i made a mistake and misunderstand the purpose of this test :)

DiouxX commented 6 years ago

it's merged

Thanks for your contribution :)