DioxusLabs / blitz

A radically modular HTML/CSS rendering engine
Apache License 2.0
2.13k stars 42 forks source link

Implement box-shadow drawing #122

Closed cfraz89 closed 2 months ago

cfraz89 commented 3 months ago

Adds support for rendering box-shadow, using the blur-rect branch of vello.

Also updates the tailwind example to render #cool with a black shadow, and #cool-inset with an inset shadow, to demo support.

Caveats

cfraz89 commented 3 months ago

Sounds good, I've reverted the formatting on the Cargo.toml.

nicoburns commented 3 months ago

Does this fix hovering the search box in the "google" example? (seach box should have shadow on hover, currently it visually disappears instead).

The vello PR has now landed. We can merge this if:

cfraz89 commented 2 months ago

Does this fix hovering the search box in the "google" example? (seach box should have shadow on hover, currently it visually disappears instead).

It does :smiley:

Screenshot from 2024-08-29 14-42-15

The vello PR has now landed. We can merge this if:

  • It is updated to use vello's main branch (some changes may be required)
  • The main vello version in Cargo.toml is updated rather than a patch applied. This may require forking vello_svg to have a compatible version.

Done. I've made a personal fork of vello_svg to depend on the updated Vello, not sure if thats acceptable or you'd rather update the fork at https://github.com/DioxusLabs/vello_svg