DioxusLabs / dioxus

Fullstack app framework for web, desktop, mobile, and more.
https://dioxuslabs.com
Apache License 2.0
21.51k stars 828 forks source link

[Docs] Web publishing mentions `trunk` rather than `dioxus` #1022

Closed Kingdutch closed 10 months ago

Kingdutch commented 1 year ago

Problem

The web publishing docs reference trunk, which seems to be http://trunkrs.dev but this isn't mentioned in the "Getting Started" of the docs. Replacing trunk by dioxus seems to give the expected result.

The pt-br translation of the getting started docs do mention trunk which suggests that this tool was previously needed but its functionality is now incorporated in the dioxus-cli and the publishing docs need to be updated, but I'm not sure if that's correct so I'm hesitant to create a PR.

If trunk is indeed no longer needed then I'm happy to PR replacing the word with dioxus :)

Questionnaire

ealmloff commented 1 year ago

Currently, the Dioxus CLI outputs release builds that are significantly larger than trunk because it doesn't integrate with wasm-opt. (For a hello world example the dioxus cli outputs builds that are 4x larger) https://github.com/DioxusLabs/cli/pull/124 adds a plugin system that can integrate with wasm-opt. Right now, adding a link to trunk would be great! Once the plugin system is part of the CLI, we can switch from trunk to the CLI for release builds

stefnotch commented 10 months ago

The URL for web publishing docs seems to have changed. Is this issue still relevant?

ealmloff commented 10 months ago

The publishing docs now uses the dioxus CLI