enhancement: Implement memoization by value of `Element`s passed as props

[marc2332]

Problem

When a component re runs and is passing an Element to another component, this other component will always rerun, because Dioxus can't seem to be able to memoize Elements.

fn app() -> Element {
    let mut show = use_signal(|| false);

    println!("Why am I running?");

    rsx!(
        div {
            onclick: move |_| {
                *show.write() = true;
            },
            p { "{show}" }
            Whatever {
                div { }
            }
        }
    )
}

#[allow(non_snake_case)]
#[component]
fn Whatever(children: Element) -> Element {

    println!("Why me too?");

    rsx!(
        div {
            {children}
        }
    )
}

Steps To Reproduce

Steps to reproduce the behavior:

• Run it

Expected behavior

Only println!("Why am I running?"); should run when the parent component re-runs if the passed children are still the same, right?

Screenshots

If applicable, add screenshots to help explain your problem.

Environment:

• Dioxus version: master
• Rust version: 1.75
• OS info: Windows
• App platform: any

[ealmloff]

This is expected behavior. VNodes currently implement partialeq by pointer. They could implement a deeper partialEq if the pointers are different, but the current behavior is pretty similar to what you would get with borrowed props with an Element in 0.4

[marc2332]

🏃

[jkelleyrtp]

We could attempt to diff them with a slightly deeper comparison