DioxusLabs / dioxus

Fullstack app framework for web, desktop, mobile, and more.
https://dioxuslabs.com
Apache License 2.0
20.05k stars 764 forks source link

Hotreload poll causes server_futures to repeatedly get called #2032

Closed jkelleyrtp closed 4 weeks ago

jkelleyrtp commented 5 months ago

Problem

We shouldn't reload the page entirely every 1 second - just check for heartbeat and then sync state. If the state is different then maybe re-running the server_futures is a good idea, but right now, reloading every future is unnecessary.

Screenshots

If applicable, add screenshots to help explain your problem.

Environment:

Questionnaire

ealmloff commented 5 months ago

I don't think we should cache server functions automatically. When the hot reload web socket tries to connect to the server every second we shouldn't be trying to render HTML because it is a web socket connection

ealmloff commented 4 weeks ago

We no longer use fullstack for hot reloading logic which fixes this issue