DioxusLabs / dioxus

Fullstack app framework for web, desktop, mobile, and more.
https://dioxuslabs.com
Apache License 2.0
20.47k stars 786 forks source link

rsx! template ToTokens is incorrectly merging attributes together #2095

Closed jkelleyrtp closed 6 months ago

jkelleyrtp commented 6 months ago

Problem

This block of rsx

    let h = rsx! {
        circle {
            cx: 50,
            cy: 50,
            r: 40,
            stroke: "green",
            fill: "yellow"
        }
    };

Only generates 1 dynamic attribute in its output when it should in fact be generating 3 dynamic nodes, causing the current failures we see with playwright tests.

Playwright caught this since we now write all watched templates out to hotreload on first load to support css hotreloading (which is admittedly a strange behavior, but interesting that it caught this).

Environment:

Questionnaire