For/If exprs not being indented properly

[XavDesbordes]

Hi,

latest dioxus: using rsx! format on save in the dioxus plugin for Vs code. Linux

pictures worth 1000 words:

Normal loop in rust with my settings:

Multi scoped, normal rust (to see the behavior when an offset is applied):

inside rsx! block at top:

inside rsx! block:

here is the loop:

for (my_dummy_data, txt) in data_full_profile
                                        .read()
                                        .0
                                        .as_ref()
                                        .unwrap()
                                        .get()
                                        .dummy_data_for_example[0]
                                        .dummy_section
                                        .iter()
                                        .zip(data_full_profile
                                                .read()
                                                .0
                                                .as_ref()
                                                .unwrap()
                                                .get()
                                                .dummy_data_for_example[0]
                                                .strs
                                                .iter())
                                {}

The wrecked indentation becomes a distraction, even more so in a longish rsx!{}

Here to provide further info if needed.

Thanks!

[jkelleyrtp]

Ah, it's because we don't apply indentation to formatted exprs in for/if loops - guess I didn't expect anyone to use multiline exprs in those cases! Should be simple enough to fix

[XavDesbordes]

I acknowledge being a jackass but it really eases the bulk of data I have to deal with. Do you recommend a specific strategy ? Preparing the iterators out of the rsx!{} block maybe ? (Genuinely open to suggestions to make the app the most efficient as possible)

[jkelleyrtp]

You could extract out to a vec/iterator of elements - this could even be a separate function to clean things up a bit

    let profile = data_full_profile.read();
    let dummy = &profile.0.as_ref().unwrap().get().dummy_data_for_example[0];
    let profiles = dummy.dummy_section.iter().zip(dummy.strs.iter()).map(|s| {
        rsx! {
            div { "Some rendered content {s}" }
        }
    });

    rsx! {
        div { {profiles} }
    };

[XavDesbordes]

That's smart and I like it. Taken :+1: !

[jkelleyrtp]

We still need to format these exprs - so I'll leave this issue open and fix it in #2230

[jkelleyrtp]

Okay cool, should be released soon, your IDE (assuming you're using vscode) will autoupdate in the next day or so

[XavDesbordes]

@jkelleyrtp you rock, really !