DioxusLabs / dioxus

Fullstack app framework for web, desktop, mobile, and more.
https://dioxuslabs.com
Apache License 2.0
19.88k stars 764 forks source link

hot reload does refresh rsx! if it contains \n #2486

Closed gusinacio closed 2 weeks ago

gusinacio commented 2 months ago
          I think I found the problem. The problem was not related to the file, but the content of the strings in the whole rsx!

I generated some code in v0, and there were some \n in the middle of the strings. The whole rsx stops reloading if one of the strings contains \n.

https://github.com/DioxusLabs/dioxus/assets/4844547/b0327733-0373-4bfa-bf43-16a2b231c889

Originally posted by @gusinacio in https://github.com/DioxusLabs/dioxus/issues/2485#issuecomment-2155248154

ealmloff commented 2 months ago

This seems similar to https://github.com/DioxusLabs/dioxus/issues/1586

ealmloff commented 2 weeks ago

fixed by #2725

jkelleyrtp commented 2 weeks ago

Did you test it locally? @ealmloff

ealmloff commented 2 weeks ago

Did you test it locally? @ealmloff

Yes, hot reloading this snippet works on desktop:

pre {
     "hello\tworld"
     "hello\nworld"
}