search

DioxusLabs / sdk

A library to provide abstractions to access common utilities when developing Dioxus applications.
Apache License 2.0
84 stars 13 forks source link

replace unmaintained actions-rs/* actions in CI workflows #9

Closed striezel closed 1 year ago

striezel commented 1 year ago

Basically all of the actions-rs/* actions are unmaintained. See https://github.com/actions-rs/toolchain/issues/216 for more information. Due to their age they generate several warnings in CI runs, for example in https://github.com/DioxusLabs/dioxus-std/actions/runs/5282023756:

Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

To get rid of those warnings the occurrences of actions-rs/toolchain are replaced by dtolnay/rust-toolchain, and the occurrences of actions-rs/cargo are replaced by direct invocations of cargo.

DogeDark commented 1 year ago

Thanks so much! I took these from the Dioxus repo so if it's still using actions-rs, it would be great if you could open a PR there too.

striezel commented 1 year ago

The PR for Dioxus has been created, too: https://github.com/DioxusLabs/dioxus/pull/1099