search

DioxusLabs / taffy

A high performance rust-powered UI layout library
https://docs.rs/taffy
Other
2.06k stars 102 forks source link

Taffy 0.3.18 crashes rustdoc build #644

Closed mintlu8 closed 5 months ago

mintlu8 commented 5 months ago

taffy version

0.3.18

Platform

Rustdoc

What you did

Compiling bevy_ui on rustdoc

What went wrong

taffy
xangelix commented 5 months ago

Builds on nightly seem broken with this.

djeedai commented 5 months ago

I'm on osx stable and same issue.

djeedai commented 5 months ago

I've tried 0.3.10 (min version for Bevy) to 0.3.18 and they all fail the same. But I don't see any other Bevy project compiling so it really looks like all those versions are broken?

djeedai commented 5 months ago

Duplicate of #642 ?

nicoburns commented 5 months ago

This is caused by https://github.com/rust-lang/rust/issues/123824 For future reference, the following version exhibits the issue when compiling Taffy 0.3.18: rustc 1.79.0-nightly (a07f3eb43 2024-04-11)

@djeedai Are you sure you're seeing this on stable Rust. I am unable to reproduce this on rust 1.77.0 or 1.77.2 on macOS (but I am seeing the failure on

nicoburns commented 5 months ago

I've published Taffy 0.3.19 which fixes the internal failure within Taffy. Although 3rd-party callers of Taffy's APIs may need to update their calls.

djeedai commented 5 months ago

No this was in nightly my bad. The project I was trying had a forced nightly in a config file, and hadn't realized. This builds with stable.