search

DiptoChakrabarty / Resume-Generator

A Resume builder which allows users to build their own custom resumes with details like experience,projects , skills ,education etc. Users can also have the feature to download their resumes . To contribute send PR at development branch from where it will be merged in master once checked.
https://generator-resume.herokuapp.com/
MIT License
37 stars 24 forks source link

Check Validity of Dates #10

Closed DiptoChakrabarty closed 3 years ago

DiptoChakrabarty commented 3 years ago

Currently we are able to select the start and end date for the users experience , education etc however there is no validation present in the routes in case the end date is before the start date which needs to be fixed .

Validate the dates provided by user and add checks for multiple validations.

importhuman commented 3 years ago

Hello! I haven't looked at the code yet, but I would like to contribute to this issue, and then more issues if possible.

DiptoChakrabarty commented 3 years ago

Hello! I haven't looked at the code yet, but I would like to contribute to this issue, and then more issues if possible.

Please go ahead @importhuman

importhuman commented 3 years ago

Thank you!

importhuman commented 3 years ago

Screenshot from 2020-09-26 17-09-37 I am unable to run the app. I have searched online here and done this in the test.py file:

app.config['SQLALCHEMY_TRACK_MODIFICATIONS'] = True

I have tried giving a False value as well. Please assist. I have tried removing the curly brackets in the .env file as well, if that is relevant.

DiptoChakrabarty commented 3 years ago

Screenshot from 2020-09-26 17-09-37 I am unable to run the app. I have searched online here and done this in the test.py file:

app.config['SQLALCHEMY_TRACK_MODIFICATIONS'] = True

I have tried giving a False value as well. Please assist. I have tried removing the curly brackets in the .env file as well, if that is relevant.

@importhuman the app seems to be running fine this is just a warning that setting SQLALCHEMY_TRACK_MODIFICATIONS as True will require extra memory and this is a common warning which comes every time you run , this will not effect the overall running of the application , if you head over to http://localhost:5000 you should see the application has started there .

importhuman commented 3 years ago

I didn't realize I had to click on the link to proceed, will see now.

Despite the .env file, we still have to sign up/log in, and the .env values still open the link even if the details are wrong.

DiptoChakrabarty commented 3 years ago

The env file values are for the mail service we are using within the application , the email used in the env is the mail through which the application users will receive emails in case they forgot password. Login and registration is independent of those values .

importhuman commented 3 years ago

What is the password for then? For the issue, I'm trying to add some sort of validation in forms.py.

DiptoChakrabarty commented 3 years ago

The password is your gmail account (through which you will send emails) password , since we need to authenticate ourselves when we need to send emails using flask mail. These values are only used when you send emails that is in the forgot password route .

importhuman commented 3 years ago

The date validity is for education, experience and project fields, correct?

DiptoChakrabarty commented 3 years ago

yes for those three