search

Direct4Ag / ag-services

1 stars 0 forks source link

add routes and modify config and readme files #21

Closed Rashmil-1999 closed 7 months ago

Rashmil-1999 commented 8 months ago

This PR mainly adds routes to fetch data from database. I have added scripts to perform create and apply migrations to the database adding alembic as a dependency. Next steps would be to add data initialization script from a source to populate the database. Right now I have only added most basic API endpoints so we can add more as required later.

navarroc commented 8 months ago

Any idea why the docker build is broken?

Rashmil-1999 commented 7 months ago

Any idea why the docker build is broken?

Yeah, I had created an issue for it after seeing the failing action

navarroc commented 7 months ago

Does there need to be a submodule link to the data or is this just for convenience? My only concern would be the kinds of data that goes in there and being public. I just wonder if we could make the data repo private and add to the readme where to get the data and if they have access, they can get it.

navarroc commented 7 months ago

Most of this looks good. I think if we remove the unused imports we should be good to merge and can address changes/fixes as we start to implement the frontend