DirectedEdges / specs-plugin

33 stars 0 forks source link

Text style not applied for Token Studio and raw values #146

Closed dlewand691 closed 6 months ago

dlewand691 commented 6 months ago

Description

After running the plugin, a text style is not added to the Token Studio reference or the raw value that's added to the end. Please update to apply a text style so these data points can be customized.

Screenshot

CleanShot 2024-03-20 at 16 18 05@2x

nathanacurtis commented 6 months ago

@dlewand691 That's interesting. I'm unsure if I'd be able to reproduce that myself for I'm not sure what's triggering that display. Would you be willing to share a sample Figma file (view only) that I'd be able to inspect and test against?

dlewand691 commented 6 months ago

@nathanacurtis Sure! See if you can get to this link. It's very much a work in progress but you'll see the areas there: https://www.figma.com/file/B9Urc5mN5LvMtFoym52YwK/Web-design-system-visuals?type=design&node-id=48%3A1037&mode=design&t=B8h3emBjww6w810N-1

nathanacurtis commented 6 months ago

@dlewand691 I'm inquiring with the TS studio team about the meaning and implications of the broken link icon in the TS studio interface and its impact on reading that plugin's "shared data" using by the specs plugin. image

nathanacurtis commented 6 months ago

@dlewand691 TS reports that:

"(the broken link symbol) should mean that there is a token applied that TS studio cannot find (in the activated token sets)."

Can you check on your side that your TS tokens are setup properly?

Danny-Cognizant commented 6 months ago

@nathanacurtis I'm not using TS in the current setup. I was initially but stopped and removed it because it was getting overly complicated. I guess may there's some lingering leftovers? I'll see what I can do to resolve this.

EDIT: I'm seeing a ton of old token links now when re-opening the TS plugin. If I delete the tokens it also deletes the layer. This is going to be a nightmare to fix.

dlewand691 commented 6 months ago

@nathanacurtis I was able to go through all my components and fix them easier than I thought. There are no broken links anywhere now. One issue remains though, the raw value at the end of the label is still not linked to a style.

CleanShot 2024-03-22 at 12 57 09@2x

dlewand691 commented 6 months ago

@nathanacurtis More formatting recommendation/requests...

CleanShot 2024-03-22 at 16 04 44@2x

nathanacurtis commented 6 months ago

Resolving here. Added #149 as separate request.