Direwolf20-MC / BuildingGadgets

Sometimes, building large structures can be a little tedious, and take a lot of effort. Not all of us are great builders you know!
https://www.curseforge.com/minecraft/mc-mods/building-gadgets
MIT License
205 stars 66 forks source link

Exchanging Gadget allows people to 'exchange' Immersive Engineering multi blocks for free. #682

Open MuteTiefling opened 2 years ago

MuteTiefling commented 2 years ago

Building Gadgets version

buildinggadgets-1.16.5-3.8.2

Minecraft Version

1.16.5

Forge Version

36.2.29

Modpack & Version

Enigmatica 6 Expert v1.0

Do you have optifine installed?

No

Describe the issue

IE Multiblocks can be selected as a block, and then 'exchanged' freely

Steps to reproduce

1) Build any IE Multiblock and form it 2) Sneak right click it with the exchange gadget 3) Now use the exchange gadget to 'place' it.

You'll only get 1 block, and a very buggy looking multiblock, but breaking it does give you a free block.

Expected behaviour

To not exchange with blocks that don't exist/the player doesn't have.

Screenshots

Easier to see in video: https://streamable.com/2wg96u

Log files

https://gist.github.com/MuteTiefling/f33ee2266d53f172dd53507ef271c770

Additional information

No response

Information

itsdinkd commented 2 years ago

You can also mine with it as free silk touch, get ancient debris, diamond ore, and especially modded ore which requires high levels of mining.

MichaelHillcox commented 2 years ago

You can also mine with it as free silk touch, get ancient debris, diamond ore, and especially modded ore which requires high levels of mining.

That's intended behaviour

MichaelHillcox commented 2 years ago

I'll look into this soon

itsdinkd commented 2 years ago

You can also mine with it as free silk touch, get ancient debris, diamond ore, and especially modded ore which requires high levels of mining.

That's intended behaviour

So getting the item you do not have yourself is intended behavior? It's the same use case as the issue describes above though, but just for different blocks. You should at least own the block you are trying to exchange.

nevermind just watched his video, definitely not the same. other than that though shouldn't you have the block you are trying to exchange from with another?

MichaelHillcox commented 2 years ago

I'm confused on what you mean here. The exchanging gadget with silk touch will exchange blocks 1 for 1. If you exchange diamonds ore with stone then that's intended. If you're extending on the main issue here and you mean you can set he gadget to a block that doesn't take from your resources but still allows you to exchange then it's the same issue and will be fixed :P

itsdinkd commented 2 years ago

Apologies, yes it's extending of what is said here. I also was able to use it on modded ore and it would actually drop the raw ore of the block. For example: use it on diamond ore even and a diamond will drop. Idk why I said silk touch

On Wed, May 4, 2022, 2:12 AM Michael Hillcox @.***> wrote:

I'm confused on what you mean here. The exchanging gadget with silk touch will exchange blocks 1 for 1. If you exchange diamonds ore with stone then that's intended. If you're extending on the main issue here and you mean you can set he gadget to a block that doesn't take from your resources but still allows you to exchange then it's the same issue and will be fixed :P

— Reply to this email directly, view it on GitHub https://github.com/Direwolf20-MC/BuildingGadgets/issues/682#issuecomment-1117089487, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIL5CKHCR6UITL55JBIJHITVII5O5ANCNFSM5RLXX4LQ . You are receiving this because you commented.Message ID: @.***>