Direwolf20-MC / BuildingGadgets

Sometimes, building large structures can be a little tedious, and take a lot of effort. Not all of us are great builders you know!
https://www.curseforge.com/minecraft/mc-mods/building-gadgets
MIT License
205 stars 65 forks source link

Can't Build in Survival Mode #684

Open KreativeKngYT opened 2 years ago

KreativeKngYT commented 2 years ago

Building Gadgets version

3.8.2

Minecraft Version

1.16.5

Forge Version

36.2.23

Modpack & Version

Immersive and More on 1.16.5, pack version 7.3

Do you have optifine installed?

Yes

Describe the issue

It works in creative mode, but in survival mode, the blocks are displayed in red and cannot be placed. The building gadget tool is is charged, I have the required block in my inventory.

Steps to reproduce

Try to build things with the building gadget in Survival mode. Even if you have the required blocks in your Inventory, hotbar or off-hand it will still show red and not let you place anything.

Expected behaviour

I expected to be able to place blocks and have the building gadget work as shown in the spotlight videos

Screenshots

2022-04-05_17 50 12

Log files

No response

Additional information

I am using Immersive Engineering power as the power source for charging the building gadget. I have not tested but this issue may be in all the other building gadgets too.

Information

MichaelHillcox commented 2 years ago

Looks like a mod conflict issue. Do you have any backpack like mods in the pacl you're playing?

KreativeKngYT commented 2 years ago

Looks like a mod conflict issue. Do you have any backpack like mods in the pacl you're playing?

yes, I am using Adventure Backpacks and Project Red also adds some backpacks.

MichaelHillcox commented 2 years ago

Does he mod work with an empty inventory and only the correct items and the gadget in your toolbar? So just an inventory with the bare essentials?

KreativeKngYT commented 2 years ago

Nope, even with just the bare essentials it won't work.

MichaelHillcox commented 2 years ago

Hay, sorry for the really slow repsonse here, does the mod work without any other mods? You can use the curseforge app to setup a new forge instance and copy over the same version of the mod into there. See if the same problem exists. It might be a pain in the ass but if it does work, I'd recommend you start adding more and more mods (in steps, testing at each step) until you find out which mod is causing issues. Once you know I can start looking into it for you and see if I can get it fixed

Huntmaster606 commented 2 years ago

I have same issue. It is conflict with Custom NPCs mod.

MichaelHillcox commented 2 years ago

Oh really! That's very helpful information, can you produce the error with just BG and Custom NPC's mod?

Huntmaster606 commented 2 years ago

According to minecraft game output there is no errors produce. The game runs fine, I can use BG in creative mode with no issue. In the survival mod, the gadgets use only construction paste, but not required blocks from the inventory. And this only happens if the Custom NPC's mod is installed.

Here is debug file, if it can be helpfull: debug.log

ace90210 commented 2 years ago

I've hit same issue and i have custom npcs as well so seems it definatelly is a bug with custom npcs no idea why though

The-Artificer commented 1 year ago

Did anyone ever find a workaround for this?

The-Artificer commented 1 year ago

I have both CustomNPCs and Building gadgets and have the same issue. I can't get rid of either because I don't want to mess up our world file.

Mystra007 commented 1 year ago

Same issue as well without optifine. Happens as soon as CustomNPC is installed. Don't see the ghost anymore to place blocks and it's like building gadgets doesn't see the inventory anymore. I can repro having just CustomNPC / building gadget and JEI placing a stone block then trying to copy-paste it. It will show stones in red as I think I don't have any despite having 63 left after placing the one to do the test. There is no errors it just doesn't seem to see the player inventory anymore with CustomNPC. I also tried with the 2 previous versions on Curseforge and tried to see if there was a config in Building Gadget or in CustomNPC.

Mystra007 commented 1 year ago

Without CustomNPC: image

With CustomNPC: image

Setup for test instance to repro (using latest customNPC snapshot not available on curseforge, same problem in curseforge version): image

MichaelHillcox commented 1 year ago

Seems like a not us issue if you ask me. Looks like they're doing something very weird... I also can't seem to find their source code anywhere?

JLC-Gaming commented 1 year ago

I'm having the same issue, but I'm on 1.19.2, and I don't have the CustomNPC mod

UziLoogies commented 1 year ago

I'm having the same issue, but I'm on 1.19.2, and I don't have the CustomNPC mod

i have the same issue on 1.19.2 as well. i do not have CustomNPC installed either

MichaelHillcox commented 1 year ago

Well, it's most likely gunna be another issue and all I can recommend to you is that you start to slowly remove mods until it starts working again

Greatone123 commented 1 year ago

Well I know for me it's the Dungeon Libraries mod, but I don't know enough about modding to really give any useful input.

UziLoogies commented 1 year ago

Well I know for me it's the Dungeon Libraries mod, but I don't know enough about modding to really give any useful input.

maybe change the version for Dungeon Libraries and see if that works? i'll try that when i get home

Croydon1115 commented 1 year ago

Did anything ever get figured out with this, I am having the same problem with customnpcs and building gadgets.

FuuNoKamiOka commented 1 year ago

Had this same issue with a custom modpack loosely based off the RAD 2 pack. I saw Greatone say Dungeon Libraries caused the issue. I took the initiative and took out the mod. It was 100% the issue and I can use the mod now. Hope it helps! :D

dayd21git commented 1 year ago

More than a year has passed and you still haven't taken measures to solve the problem?! For what purpose did you create a repository and open discussions? @MichaelHillcox

MichaelHillcox commented 1 year ago

What? It's someone else's mod that is causing the issue...

dayd21git commented 1 year ago

What? It's someone else's mod that is causing the issue...

I can't find a list of mods that your modification conflicts with. Can I get a link to this information? A lot of time has passed and you have been repeatedly complained about the conflict with some mods. One of these mods is a CustomNPC. I suspect that if your mod conflicts with several other mods at once, then the problem is not in other mods, but in yours.

Please, if you don't have enough skills to solve this problem, post a WARNING that will give a possible list of problematic mods. This will allow to immediately remove the problematic mod from the modpack without wasting time searching. Maybe people just won't download your mod after seeing this warning.

MichaelHillcox commented 1 year ago

xD This is a good read... Kinda rude but funny regardless... The issue comes from the two mods existing in the same pack. We're doing nothing special or out of the common modded ecosystem, meaning that the conflicting mods are likely the ones causing issues but I'm yet to have found the time to focus on looking at the direct cause. If someone else has the time to narrow it down, I'll more than happily try and fix it if I can.

As you've already mentioned, the mod is open source, you're more than welcome to support the project by digging into issues instead of complaining about my skill or the length of time the issue has been open for.

dayd21git commented 1 year ago

xD This is a good read... Kinda rude but funny regardless... The issue comes from the two mods existing in the same pack. We're doing nothing special or out of the common modded ecosystem, meaning that the conflicting mods are likely the ones causing issues but I'm yet to have found the time to focus on looking at the direct cause. If someone else has the time to narrow it down, I'll more than happily try and fix it if I can.

As you've already mentioned, the mod is open source, you're more than welcome to support the project by digging into issues instead of complaining about my skill or the length of time the issue has been open for.

I'm not complaining about skills, but about the lack of a warning. I, as an ordinary player, spent a lot of time to understand that the mod does not work. And even more time to search for information about this bug. A normal warning would save a lot of time.

As for my message, I apologize if something seems rude. I use a translator and don't speak English. The meaning of the text can be distorted, alas.

I would suggest that you release a debug version in which you could compare the identity of the block in the inventory and the block that the gadget remembered. I think that way you could understand what's going on.

MichaelHillcox commented 1 year ago

My mistake, it's very easy to take translated English as rude. it's not an easy language to translate into.

Regardless, if we can isolate the mods that BG conflicts with, that would be a good start in finding the root cause. I see that CustomNPC's is a cause. Are there any others we know about?

dayd21git commented 1 year ago

My mistake, it's very easy to take translated English as rude. it's not an easy language to translate into.

Regardless, if we can isolate the mods that BG conflicts with, that would be a good start in finding the root cause. I see that CustomNPC's is a cause. Are there any others we know about?

I don't know any more similar problems. I have installed Construction Wand and it does not conflict with anyone. Perhaps you should look at the implementation in the specified mod and extract something for your experience.

Mystra007 commented 11 months ago

What? It's someone else's mod that is causing the issue...

They says exactly the same. The only difference is they are closed source. That make everything their fault according to the forge community it seems. Meanwhile users with these 2 mods are stuck between the tree and the bark and nobody seems to want to do anything and nobody in these 2 mods are talking to each other to try to fix it either and everybody think they are perfect coders and can never make any tiny mistake or have tiny bugs. Clearly building gadgets isn't liking something from customnpcs rendering or it's the opposite and its prevented from seeing items in the inventory as well. All I'm saying is that sometimes two developers talking can do anything while as a normal user I'm never going to be helpful to either of you because you know coding mods and I dont.

dayd21git commented 11 months ago

What? It's someone else's mod that is causing the issue...

They says exactly the same. The only difference is they are closed source. That make everything their fault according to the forge community it seems. Meanwhile users with these 2 mods are stuck between the tree and the bark and nobody seems to want to do anything and nobody in these 2 mods are talking to each other to try to fix it either and everybody think they are perfect coders and can never make any tiny mistake or have tiny bugs. Clearly building gadgets isn't liking something from customnpcs rendering or it's the opposite and its prevented from seeing items in the inventory as well. All I'm saying is that sometimes two developers talking can do anything while as a normal user I'm never going to be helpful to either of you because you know coding mods and I dont.

I'm begging you... I doubt that the CustomNpc are to blame here, because other similar mods do not have such a conflict. But you're right, developers are too arrogant. I have given two options to solve the problem, but no measures have been taken.

dje4321 commented 9 months ago

Well I know for me it's the Dungeon Libraries mod, but I don't know enough about modding to really give any useful input.

maybe change the version for Dungeon Libraries and see if that works? i'll try that when i get home

Known issue with Dungeon Libraries. Pull request with patch that fixes the issue available here. https://github.com/Infamous-Misadventures/Dungeons-Libraries/pull/43