Direwolf20-MC / JustDireThings

Just some things Direwolf20 wants to have.
MIT License
33 stars 10 forks source link

Tree Feller not triggering accelerated leaf decay #128

Closed NielsPilgaard closed 4 weeks ago

NielsPilgaard commented 4 weeks ago

Just Dire Things version

1.0.1

Minecraft Version

1.21.0

(Neo)Forge Version

21.0.166

Modpack & Version

Enigmatica 10 v1.8.0

Do you have optifine or Rubidium installed?

I have other rendering based mods installed

Describe the issue

When using the Tree Feller upgrade on a JDT Blazegold axe, leaves do not decay fast and instead follow vanilla leaf decay. In case it matters the axe had the Silk Touch and Efficiency 4 enchants.

Steps to reproduce

  1. put Tree Feller on a Blazegold axe
  2. Cut down tree
  3. See leaves remain

Expected behaviour

For the leaves to rapidly decay when the tree is gone

Screenshots

No response

Log files

No response

Additional information

Original issue: https://github.com/EnigmaticaModpacks/Enigmatica10/issues/84

Direwolf20-MC commented 4 weeks ago

It seems to be working in my Dev Environment - could it be another mod causing it?

https://github.com/user-attachments/assets/c310d384-80ed-4008-b61f-f86344a1b0d9

NielsPilgaard commented 4 weeks ago

Yeah could be - Would you mind trying with Silk Touch + Efficiency 4 on the Axe? I forgot to mention the reporter had that πŸ˜…

Direwolf20-MC commented 4 weeks ago

You did mention it, i forgot to test with those enchants - but yea no difference.

https://github.com/user-attachments/assets/fe6229c7-09b7-4fcd-ba4a-a6d417947ea1

NielsPilgaard commented 4 weeks ago

Oh so I did πŸ˜‚

Did you use Accelerated Decay in your test, or another leaf decay mod?

Direwolf20-MC commented 4 weeks ago

Yup thats the one :). I looked at the modlist for the pack, and grabbed the one from it.

NielsPilgaard commented 4 weeks ago

I tested it in Enigmatica in-dev and it's working fine - thanks for the help, and sorry for taking your time 😊

Direwolf20-MC commented 4 weeks ago

Awesome :). It’s definitely possible it was only fixed in the past 2 versions. I changed how breaking works.

NielsPilgaard commented 4 weeks ago

That's reassuring :D