Fluid Cannister - Githubissues

Direwolf20-MC / JustDireThings

Just some things Direwolf20 wants to have.

MIT License

43 stars 16 forks source link

Fluid Cannister #203

Open MaterousApps opened 1 month ago

MaterousApps commented 1 month ago

Just Dire Things version

1.4.2

Minecraft Version

1.21.1

(Neo)Forge Version

21.1.61

Modpack & Version

Direwolf20-11

Do you have optifine or Rubidium installed?

No

Describe the issue

Fluid canister cannot extract/fill cauldrons

Steps to reproduce

Set up dripstone to fill a cauldron with water or lava
Once full try to extract using fluid canister
Accidentally place lava at your feet

Expected behaviour

To be able to extract/place fluid from a cauldron

Screenshots

No response

Log files

No response

Additional information

No response

dmvgbs commented 1 month ago

You are right, I was able to reproduce this behaviour.

There's currently only a check for LiquidBlock which implements BucketPickup. In this case for example LavaCauldronBlock is not deriving from LiquidBlock so this needs to be handled differently I think.