Dirli / budgie-weather-applet

Dlsplays the current weather for the selected location
GNU General Public License v2.0
5 stars 2 forks source link

Panel crashes searching for location #6

Closed vredesbyyrd closed 5 years ago

vredesbyyrd commented 5 years ago

ENV info:

Hi, I have been testing the latest changes and they look great. Although I have ran into an issue on commit 9155fb80cfcaaf79563c3c30d010b9a600ee2ca5

Here is the log for the panel crash when searching. I am not very familiar with vala, but if there is anything I can do let me know.

budgie-weather-crash-log.txt

vredesbyyrd commented 5 years ago

Interesting, I just discovered the same (or similar) crash is occurring when searching for locations with Meteo and Gnome-Weather. So this is not limited to your plugin. I will look into this further.

meteo-crash.txt

Dirli commented 5 years ago

Describe in more detail what search means:

Today I will be testing for debian, gento. I will try to check.

vredesbyyrd commented 5 years ago

Sorry about that.

Manual search when connected to network causes crash. Automatic location detection works great and is a nice feature. Although I use a vpn often so manually selecting the location is preferred.

It appears to crash when parsing certain locations. I have not been able to find a rhyme or reason yet. Will investigate further.

https://imgur.com/a/Weq7t9a

vredesbyyrd commented 5 years ago

Looks like geocode-glib is responsible, and there are fixes in master. Will try to compile with the fixes and report back.

https://gitlab.gnome.org/GNOME/geocode-glib/commit/e1a6b067dc42618992787e84aadad2ca27ae0017

vredesbyyrd commented 5 years ago

Geocode-glib is indeed responsible. I compiled geocode-glib with the latest fixes and manually searching now goes smoothly.

And I just realized I should have filed a separate bug for the 2nd issue. Was very tired when I reported this last night. Ill close this and resubmit the unrelated issue.

detecting/setting metric or imperial units automatically based on location does not work