first step for moving to TypeScript

Dirnei / node-red-contrib-zigbee2mqtt-devices

Node-red nodes for controlling and managing zigbee devices managed by zigbee2mqtt

MIT License

30 stars 7 forks source link

first step for moving to TypeScript #63

Closed MrSpoocy closed 3 years ago

MrSpoocy commented 3 years ago

First step, try it and tell me what is wrong :)

Change folder structure
mqtt-config -> TypeScript
zigbee2mqtt-config -> TypeScript
types.ts (currently all types included, need to split for each node)
add devDependencies
add build command (copy the html, svg .. files)

Andreas-Huber commented 3 years ago

Can you add the dist folder to the .gitignore? And also add npm install typescript --save-dev to the project?

Andreas-Huber commented 3 years ago

Ah, and what I forgot to mention, of course, delete the dist folder from the commits :-)

I'm also wondering, why git detected the move for the .js files - but not for the .HTML files. I don't think it there is anything wrong with those files, it just breaks the git history if you want to go back for some reason.

I'll test it a bit later.

MrSpoocy commented 3 years ago

Andreas-Huber commented 3 years ago

Ok, looks good. Let's merge it and continue in the typescript branch :-)