DirtDiglett / Pressure-for-Steam

A skin to improve the visual aesthetics of Steam
Other
513 stars 117 forks source link

[Linux] In-Game Settings items misaligned #450

Closed probwebdev closed 7 years ago

probwebdev commented 8 years ago

Linux Steam Beta Client Mar 16 2016 package versions 1458187800. On Windows everything is fine. screenshot from 2016-03-17 15-49-08 screenshot from 2016-03-17 15-43-38

bykidi commented 8 years ago

try beta steam. You don't have new options that vanilla steam skin should have. //edit nevermind. ignore me.

FlamingFox911 commented 8 years ago

My bad, I know what the error is and I will fix it shortly. I'll upload a fix near the end of the day.

probwebdev commented 8 years ago

@FlamingFox911 thank you @bykidi I'm on beta. Look at the beginning above the first screenshot :)

FlamingFox911 commented 8 years ago

Hi @rgiyf, I think I have the solution but I can't test it on Linux or OSX. Here is my current solution: http://pastebin.com/G9NU8uap Copy all this into Steam\skins\Pressure-for-Steam\resource\layout\subpaneloptionsingame.layout. I highly recommend making a backup before doing so. Please let me know if it worked or nah.

probwebdev commented 8 years ago

@FlamingFox911 Yeah, it worked but maybe if possible add a little bit more gap where is "In Game Server Browser"(look at screenshot). Also checked it on Windows just in case. Everything fine. And I'm also don't have OSX. screenshot from 2016-03-17 22-28-02

FlamingFox911 commented 8 years ago

Okay, made an adjustment... see if it works. Same code again, same instruction.

probwebdev commented 8 years ago

Something with text screenshot from 2016-03-17 23-20-38

FlamingFox911 commented 8 years ago

Test again, please.

probwebdev commented 8 years ago

Same :(

FlamingFox911 commented 8 years ago

Ok. My brain it completely fried. I don't know how to move/adjust the second divider. It has no control entity. I shuffled back the pastebin to the original fix for the moment, so use that (despite its ugliness). I need time to figure this out, unless someone can tell me how to move the second divider.

Sorry ;~;

probwebdev commented 8 years ago

@FlamingFox911 no probs. Everything is fine. Listen... it was a blind guess and a few tries but try line 112 set to y=48, seems it helped :) screenshot from 2016-03-18 00-43-21

FlamingFox911 commented 8 years ago

That was my original solution (and I should have gone with that), but it is not the best. See how there is alot of space between the 2nd divider and the Screenshot options? I've changed the code in the pastebin again. Try and use that. It should appear the same.

probwebdev commented 8 years ago

@FlamingFox911 sorry, I will try tomorrow 😶

probwebdev commented 8 years ago

@FlamingFox911 that is from pastebin screenshot from 2016-03-18 09-33-29

FlamingFox911 commented 8 years ago

Ok. Good. It works. Not the best solution, but it will have to do for the moment. I'll make a pull request as soon as I can.

bykidi commented 8 years ago

Do you have fonts properly installed or it's linux-specific problem?

OK Cancel texts in buttons are lower than expected

High contrast color checkbox text cuts off, see that "g"

probwebdev commented 8 years ago

@bykidi it's a linux "specific". Unfortunately it's how fonts are rendering. They are a little bit bigger in Linux client compared to Windows client. Back in a day when client was in beta stages @DirtDiglett made some adjustments for better look between platforms. So it's how it is.

FlamingFox911 commented 8 years ago

Alrighty. I have created the pull request (#452).

probwebdev commented 8 years ago

@FlamingFox911 yay😃 thanks