Closed Dave247 closed 7 years ago
There was a very minor new bug that came up by fixing the column select button in small mode, a tiny white line next to the button that I gave up on as I have no idea what was causing it.
I probabbly should explain what the changes in 0132f006cc09b2bfa6f274e4ee1b231ce5b59ee0 are sorry.
The first lot of changes under ListPanelColumnSelectButton
was an undocumented bug, where the area the icon sits was completely white. The simplest fix I found was to change the fill colour to match in Large Mode, however a new problem appeared, as seen in my previous comment. I looked into it but have no idea what is causing the issue though so I don't know how to fix it, but still pushed the change as it looks better now then before.
The second lot of changes under ListPanelSectionHeader
were in relation to #80 and #87, where the categories were not changed to match the dark mode design.
The final change of width=max
under control=library_search
is the simplest way to fix another undocumented issue that I came across myself, where the library_filters
button not being aligned to the right of the window if you were to widen it far enough, as shown in the screenshot below (though I don't know why anyone ever would though).
Seeing as the only changes to the files were layout related, I simply cherry-picked the existing two fixes from the master branch into the dark-mode branch