Disane87 / spoolman-homeassistant

Spoolman home assistant integration 🏠
MIT License
54 stars 4 forks source link

fix: Fix key access to possibly non-existent location #88

Closed hvraven closed 7 months ago

hvraven commented 7 months ago

The location may be non-existent in the returned data. This is correctly handled in the main code, but not in the logging entries, possibly breaking the data update of the integration.

This change also simplifies the handling of a missing location in the main code flow to have it consistent between the locations.

Disane87 commented 7 months ago

Had to revert and reopen this because of missing use of conventional commits. Added a section in the readme about "proper" contributing. Everything fine with this PR but I didn't mentioned this :)

Disane87 commented 7 months ago

:tada: This PR is included in version 0.4.1-dev.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

Disane87 commented 7 months ago

:tada: This PR is included in version 0.4.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: