DiscipleTools / disciple-tools-bulk-magic-link-sender

disciple-tools-magic-links
Other
2 stars 7 forks source link

ML#124 - Ensure Expired Links Fail Gracefully #125

Closed kodinkat closed 10 months ago

kodinkat commented 11 months ago
corsacca commented 11 months ago

@kodinkat this will make sure all links are expired if the expired value isn't set?

corsacca commented 10 months ago

@kodinkat returning expires tomorrow seems like it could cause missinformation

Instead, in the places where determine_links_expiry_point is called, like in has_links_expired and fetch_links_expired_formatted_date, can we return from there if expiry not set?

corsacca commented 10 months ago

THanks @kodinkat !