search

DiscipleTools / disciple-tools-mobile-app

The React Native code base for the Disciple.Tools mobile app
https://disciple.tools/
15 stars 19 forks source link

feat: show contact status colour in PostChips #719

Closed squigglybob closed 2 years ago

squigglybob commented 2 years ago

resolves #531

squigglybob commented 2 years ago

@mikeallbutt @zdmc23 how does this look? let me know if I'm on the right kindof track

image

Since this ticket was first made, the contact select fields have had contact colours added to them, so I've been moving towards that way

image

zdmc23 commented 2 years ago

@squigglybob Nice! I do worry that since status color is configurable, coloring the entire chip could present a problem if they chose black for archived or something. How about if the left rounded side was the status color and the 'body' of chip was consistent?

squigglybob commented 2 years ago

yeah I was wondering about that too 🙂

squigglybob commented 2 years ago

One thing to note, is that the Chip can already cope well with black as the background as show on the group status screen

Screenshot_20220915-143420_2

I can still do a left patch, and that would also match the web app more closely as they use a left bar to denote the colour

squigglybob commented 2 years ago

This is how it looks now... Screenshot_20220915-164926_2

not sure why the grey one slightly overlaps at the bottom 🙁 but I massively prefer this to the full chip colour.

It's a little less sore on the eyes 🙂