search

DiscipleTools / disciple-tools-prayer-campaigns

Saturation prayer subscription extension for Disciple.Tools.
Other
2 stars 7 forks source link

Js date localization #356

Closed micahmills closed 1 month ago

micahmills commented 1 month ago

There were a few places in the JS that we were not using the pages locale but defaulting to the browsers locale. This should fix that in most places.

micahmills commented 1 month ago

There is one other place that I see the AM/PM not being translated but that string appears to come from the DB. In Subscription Management (see the screenshot).

Screenshot 2024-07-30 at 8 38 59 PM

This appears to come from https://github.com/DiscipleTools/disciple-tools-prayer-campaigns/blob/0b64514631de42ba80ebfbe2f6a9cdf96fff3b47/post-type/dt-subscriptions.php#L209, but I could be wrong about that.

corsacca commented 1 month ago

@micahmills instead of including the locate each time we could set it globally on luxon as so: https://github.com/DiscipleTools/disciple-tools-prayer-campaigns/pull/359