search

DiscipleTools / disciple-tools-web-components

https://jade-chebakia-17493f.netlify.app/?path=/story/kitchen-sink--kitchen-sink
GNU General Public License v2.0
3 stars 8 forks source link

Rounded button improvements #55

Closed incraigulous closed 1 year ago

incraigulous commented 1 year ago

Safari was not rendering rounded buttons properly, which led me to discover that Safari and Chrome handle custom property definition inheritance differently.

When defining a custom properly, safari does not use specificity when determining which variable declaration is applied first, which makes using class-based property overrides impossible unless you use different variable names.

I also added a few new custom properties.

netlify[bot] commented 1 year ago

Deploy request for jade-chebakia-17493f rejected.

Name Link
Latest commit e1a3ea9215962694107fa22708904787af6cd23e
incraigulous commented 1 year ago

@micahmills It looks like I still don't have the ability to merge. Any idea why npm ci is failing? It works for me locally.

incraigulous commented 1 year ago

@micahmills, nvm rebasing on DiscipleTools/disciple-tools-web-components:master instead of thecodezone/disciple-tools-web-components:master solved it. Mind reviewing/merging?