DiscipleTools / disciple-tools-web-components

https://jade-chebakia-17493f.netlify.app/?path=/story/kitchen-sink--kitchen-sink
GNU General Public License v2.0
3 stars 8 forks source link

Fixing safari modal height bug #62

Closed incraigulous closed 1 year ago

incraigulous commented 1 year ago

.dt-modal was stretching to the full height of the screen on Safari instead of collapsing to child height as it does on other browsers. The modal's grid structure is set on the form element, not the .dt-modal element, so I changed .dt-modal to be block instead of grid and collapsed it using height: fit-content.

Screenshot 2023-05-22 at 12 00 25 PM

Screenshot 2023-05-22 at 12 00 08 PM

netlify[bot] commented 1 year ago

Deploy Preview for jade-chebakia-17493f ready!

Name Link
Latest commit ecc9b9205cfd0a5e465d43dfef3c3728ef35c12c
Latest deploy log https://app.netlify.com/sites/jade-chebakia-17493f/deploys/646ba113339122000860db0b
Deploy Preview https://deploy-preview-62--jade-chebakia-17493f.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

cairocoder01 commented 1 year ago

Confirmed. Thanks!