search

DiscipleTools / disciple-tools-web-components

https://jade-chebakia-17493f.netlify.app/?path=/story/kitchen-sink--kitchen-sink
GNU General Public License v2.0
3 stars 8 forks source link

multi-select button group component #64

Closed corsacca closed 4 months ago

corsacca commented 1 year ago

Is this the right track?

@todo

image
netlify[bot] commented 1 year ago

Deploy Preview for jade-chebakia-17493f ready!

Name Link
Latest commit cb239be4946a17411b5d4098ab4474838a368720
Latest deploy log https://app.netlify.com/sites/jade-chebakia-17493f/deploys/64905a9f5c19b200087ff1e3
Deploy Preview https://deploy-preview-64--jade-chebakia-17493f.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

micahmills commented 1 year ago

yes this looks good. I will hold off on merging it until it is finished, but it looks good.

You can probably see the css variable naming convention, but if you have any questions let @cairocoder01 or I know.

cairocoder01 commented 1 year ago

This is looking good to me. At one point I had thought of making this via a display type attribute on the multi-select since that is more like how it's configured in the DT field config. I'm fine with this approach though.

corsacca commented 1 year ago

The button approach is nice in a < 10 items config. If we use 1 component, it could auto switch or be configurable. The typeahead is better when there are a lot of items.

corsacca commented 3 months ago

@micahmills was this implemented somewhere else? I would like to keep the button approach for multi-selects.

micahmills commented 3 months ago

We are working on it this week. It will be an attribute on the multi-select to make it a button group view