search

DiscipleTools / disciple-tools-web-components

https://jade-chebakia-17493f.netlify.app/?path=/story/kitchen-sink--kitchen-sink
GNU General Public License v2.0
3 stars 8 forks source link

Changes for dt-tag and dt-connection option list to exclude selected options #77

Closed Vijenderrr closed 4 months ago

Vijenderrr commented 5 months ago

Hi @micahmills

  1. We have made code changes to exclude the selected Items from the options list in Dt-Connection, Dt-Tags & Dt-Multiselect components. I.e. those components that fetched its option list(dropdown) from API. The following files have been changed.
    • src\components\form\dt-multi-select\dt-multi-select.js
    • src\components\form\dt-tags\dt-tags.js
    • src\components\form\dt-connection\dt-connection.js
    • src\components\form\mixins\hasOptionsList.js
    • src\services\componentService.js
      1. On the Edit detail page in the DT Theme, the Options List for Dt-connection-related fields also displayed the particular user (current user). That must be excluded from the list. We have made these changes in the File src\services\componentService.js at Line No.: 98

Could you review the changes and give us your feedback? Thanks!

@Ashima-Arora @gp-birender

netlify[bot] commented 5 months ago

Deploy request for jade-chebakia-17493f pending review.

Visit the deploys page to approve it

Name Link
Latest commit f32e2075b28faf3a2091632e5b3cac5857b8b23a