search

DiscipleTools / disciple-tools-web-components

https://jade-chebakia-17493f.netlify.app/?path=/story/kitchen-sink--kitchen-sink
GNU General Public License v2.0
3 stars 8 forks source link

Changes for dt-comm-channel #83

Closed Vijenderrr closed 3 months ago

Vijenderrr commented 4 months ago

@micahmills We have made changes in

  1. componentService.js (src\services\componentService.js)
  2. dt-comm-channel.js (src\components\form\dt-communication-channel\dt-comm-channel.js)
  3. dt-form-base.js (src\components\form\dt-form-base.js)

for dt-comm-channel to fix the component's Add, Edit and Delete functionality and general fixes.

Kindly look in the changes and provide us with your feedback. Thanks!

@Ashima-Arora @gp-birender

netlify[bot] commented 4 months ago

Deploy request for jade-chebakia-17493f pending review.

Visit the deploys page to approve it

Name Link
Latest commit c6d148d217667b2cbd987647c1468b072006f2c5
micahmills commented 4 months ago

@Vijenderrr

@cairocoder01 is one of the other creators and maintainers of the web components repo. He was working with them today so I asked him to review this PR for me. If you have any questions let me know.

Vijenderrr commented 4 months ago

@micahmills @cairocoder01 We are looking into it and work accordingly.

Vijenderrr commented 4 months ago

@micahmills Please check the latest commit and let us know your feedback.

@Ashima-Arora @gp-birender