search

DiscipleTools / disciple-tools-web-components

https://jade-chebakia-17493f.netlify.app/?path=/story/kitchen-sink--kitchen-sink
GNU General Public License v2.0
3 stars 8 forks source link

Dt dropdown web component #90

Closed Vijenderrr closed 3 months ago

Vijenderrr commented 3 months ago

@micahmills We have made a new web component named 'dt-dropdown'. For this, we have created and updated some files listed below:

  1. index.js (index.js)
  2. dt-dropdown.js (src/components/form/dt-dropdown/dt-dropdown.js)(new)
  3. dt-dropdown.stories.js (src/components/form/dt-dropdown/dt-dropdown.stories.js)(new)
  4. dt-dropdown.tests.js (src/components/form/dt-dropdown/dt-dropdown.test.js)(new)
  5. index.js (src/components/form/index.js)
  6. kitchen-sink.stories.js (src/components/kitchen-sink.stories.js)
  7. dt-modal.js (src/components/layout/dt-modal/dt-modal.js)
  8. App.js (samples/react-include/src/App.js)
  9. index.html (samples/html/index.html)

There are also some changes in the 'dt-modal' web component. Tests are yet to be configured.

Kindly look in the changes and provide us with your feedback. Thanks!

@Ashima-Arora @gp-birender

netlify[bot] commented 3 months ago

Deploy request for jade-chebakia-17493f pending review.

Visit the deploys page to approve it

Name Link
Latest commit a776956698a0926af24a83af14fb681ab21df4c4
micahmills commented 3 months ago

Thanks @Vijenderrr. This looks good and is ready to merge. It looks like we have a test file, but all the test are failing. try running npm run test or npm run test:watch to see which tests are failing. Once we have the tests passing I will merge it in.