Fix CommandExecuted not invoked on failed parse

Discord-Net-Labs / Discord.Net-Labs

An experimental fork of Discord.Net that implements the newest discord features for testing and development to eventually get merged into Discord.Net

https://labs.discordnet.dev

MIT License

156 stars 42 forks source link

Fix CommandExecuted not invoked on failed parse #384

Closed adamgauthier closed 2 years ago

quinchs commented 2 years ago

Waiting on @Cenngo's review

adamgauthier commented 2 years ago

I think this problem was introduced with https://github.com/discord-net/Discord.Net/pull/1700, I don't actually know if this is the best fix possible to be honest. @Cenngo

Cenngo commented 2 years ago

actually i was going to suggest the same fix. Im will propably rewrite command parsin logic at some point to fix discord-net/Discord.Net#1635 but for the time being rhis should do.