Discord4J / connect

Distributed bot tools for Discord4J
https://discord4j.com
GNU Lesser General Public License v3.0
14 stars 4 forks source link

Dependency-update of discord4j (use 3.2.1 instead of 3.1.x) #10

Closed theyellow closed 2 years ago

theyellow commented 2 years ago

There are problems with compatibility between connect 0.6.8 and discord4j 3.2.1. For example the following error occured:

2022-03-12 23:38:35.345 main DEBUG o.s.b.a.ApplicationAvailabilityBean - Application availability state ReadinessState changed to ACCEPTING_TRAFFIC
Exception in thread "main" java.lang.reflect.InvocationTargetException
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.base/java.lang.reflect.Method.invoke(Unknown Source)
at org.springframework.boot.loader.MainMethodRunner.run(MainMethodRunner.java:49)
at org.springframework.boot.loader.Launcher.launch(Launcher.java:108)
at org.springframework.boot.loader.Launcher.launch(Launcher.java:58)
at org.springframework.boot.loader.JarLauncher.main(JarLauncher.java:88)
Caused by: java.lang.NoSuchMethodError: 'void discord4j.rest.request.RouterOptions.<init>(java.lang.String, discord4j.common.ReactorResources, discord4j.rest.http.ExchangeStrategies, java.util.List, discord4j.rest.request.GlobalRateLimiter, discord4j.rest.request.RequestQueueFactory)'
at discord4j.connect.rsocket.router.RSocketRouterOptions.<init>(RSocketRouterOptions.java:47)

So i updated the connect-library myself, hope it will be ok. Also the examples are tested and adapted.

quanticc commented 2 years ago

Thanks a lot for the PR, I'll review it going into the weekend

theyellow commented 2 years ago

Ups, i was developing on JDK 17, i'll look for backward-compatibility later and push it.