search

Discord4J / connect

Distributed bot tools for Discord4J
https://discord4j.com
GNU Lesser General Public License v3.0
14 stars 4 forks source link

Builders #3

Open ByteAlex opened 4 years ago

ByteAlex commented 4 years ago

For consistency between Discord4J and connect package, the components should be constructed with builders aswell.

quanticc commented 4 years ago

Can you give us some example to understand and then prioritize?

ByteAlex commented 4 years ago

Sure, sorry I thought it would be clear by the name :P

Connect-module initializes a lot of objects still with the "new" keyword as of this example: new RSocketGlobalRouterServer(routerServerAddress, BucketGlobalRateLimiter.create(), Schedulers.parallel(), RequestQueueFactory.buffering())

D4J's paradigm was to use builders whereever possible, so I opened a ticket to review the connect module and add builders where possible.