search

DiscordSRV / Staff-Chat

A staff-chat plugin that hooks into DiscordSRV
MIT License
29 stars 11 forks source link

Folia Support for Discord Staff Chat? #41

Open Agaloth opened 1 year ago

Agaloth commented 1 year ago

https://github.com/PaperMC/Folia

Here is a summary of everything made with ChatGPT to save some time:

For plugin developers, there are a few key takeaways from the given text:

  1. Folia introduces regionised multithreading, which means that plugins will require modification to function properly. Plugin developers should expect compatibility with existing plugins to be at zero.

  2. Folia introduces new API additions, such as the RegionisedScheduler and EntityScheduler, which can help plugins run on the correct thread context.

  3. To ensure compatibility with Folia, plugin developers must mark their plugin as compatible by placing "folia-supported: true" in the plugin.yml file. Additionally, plugins must take advantage of the RegionisedScheduler and EntityScheduler API to ensure correct behavior.

  4. Plugins should not assume that they can access or modify data in other regions, as Folia regions tick in parallel and do not share data. Plugin developers should take advantage of the upcoming thread-check API to ensure correct behavior.

  5. There are currently broken API, including the scoreboard API, and planned API changes, such as super aggressive thread checks, which may impact plugin development.

Overall, plugin developers should be prepared for significant changes in their plugins to ensure compatibility with Folia. They should take advantage of the new API additions and mark their plugin as compatible to ensure correct behavior. Additionally, they should be aware of the limitations and rules of Folia's regionised multithreading to avoid bugs and errors in their plugins.

RezzedUp commented 1 year ago

Probably not something to look into until the project is more stable/mature. Although, since this plugin really only interacts with chat, adding support shouldn't be too difficult when the time comes.

RezzedUp commented 1 year ago

Oh, and we'll have to wait and see what DiscordSRV itself does first.

Agaloth commented 1 year ago

Yeah no problem, it will take time anyways, I'll make sure to run some tests and let you know if there are any issues :P